Parse path name lines live and festoon callbacks with error handling#473
Merged
Parse path name lines live and festoon callbacks with error handling#473
Conversation
…in base path space or [null, null]
Member
Author
|
I've also synced up subpath handling with vgteam/vg#4522 so that we can do the coordinate bars in terms of base paths, and handle queries in either base paths or single subpaths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #472 in two ways.
We no longer make one giant string of all the path names (though we do call
res.json()with one giant object), and we now have some error handlers in the callbacks in that call (but not others) that catch errors and callnext().